Skip to content

Support for Redis connection without SSL certificate verification #2#1397

Open
tomash wants to merge 1 commit into
Shopify:mainfrom
tomash:redis-verify-ssl-env
Open

Support for Redis connection without SSL certificate verification #2#1397
tomash wants to merge 1 commit into
Shopify:mainfrom
tomash:redis-verify-ssl-env

Conversation

@tomash

@tomash tomash commented Apr 18, 2025

Copy link
Copy Markdown

A twin of byroot/pubsubstub#2

Context: on Heroku Key-Value addon (Valkey fork of Redis), they use TLS but with a self-signed certificate, as described here:

This PR adds REDIS_SSL_VERIFY environment variable to make it work without patching Shipit's top-level module in-application.

No test coverage because no existing spec covers Redis connection.

@tomash

tomash commented Apr 18, 2025

Copy link
Copy Markdown
Author

I have signed the CLA!

@casperisfine

Copy link
Copy Markdown
Contributor

Sorry for the slow response I was at a conference. Just like for pubsubstub, there is a redis= method so that you can do all the custom configuration you need. So I don't think this is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants