v3 Skill facade#396
Merged
Merged
Conversation
…l/servers + ToolResult
…+ add_skill_command
…readed_execution/llm_call, private secret_keeper, read-only settings, add self.log)
…onversation.add_assistant)
…sitional interrupt, source_type/logo, helper threading)
…n->run_in_thread, conversation.add_assistant
…_changer/file_manager/image_generation/spotify/thinking_sound to v3 facade
…layback_* removed)
… imports in v3 guide
…Error on removed v2 members; drop dead imports
…estore HUD tool icons via facade
…io.set_output_device (drop HTTP hack + backend_port)
db08705 to
4265ec0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
#364 #395
Summary
Introduce a new and clearer facade layer for Skills allowing us to control and error-handle what Skills can and can’t do.
Skills v3 API — Migration Guide for Skill Developers
v3 makes the skill ↔ runtime boundary explicit. Your skill now talks to the runtime only through
self.wingman(a controlled facade with feature namespaces) and keeps its own concerns onself. Full reference + complete mapping table: MIGRATING-TO-V3.md.Mandatory (or your skill won't load)
Add
api_version: 3to yourdefault_config.yaml. Skills without it are shown as "Incompatible (legacy)" and are skipped at boot (the app still starts).The 5 breaking changes
api_version: 3in the manifest.__init__/validate()/prepare().self.llm_call(...)is gone → useself.wingman.ai.generate(...)(capped),self.wingman.ai.converse(...), or the free local modelself.wingman.local_ai.generate(...)/.summarize(...).self.wingman.configreads live values; writes raiseFacadeError. Change things through capabilities (self.wingman.tts.set_voice(...),self.wingman.commands.*,self.wingman.audio.set_output_device(...)). Runtime TTS-provider switching is removed.audio_player, the registries (tool_skills/mcp_registry/skill_registry),messages,secret_keeper,towerare gone → use the feature namespaces.Most common renames
await self.llm_call(msgs)await self.wingman.ai.generate(prompt, system=..., messages=...)await self.wingman.play_to_user(t, no_interrupt=True)await self.wingman.tts.speak(t, interrupt=False)self.wingman.get_conversation_history()self.wingman.conversation.history()await self.wingman.add_assistant_message(c)await self.wingman.conversation.add_assistant(c)await self.retrieve_secret(name, errors)await self.wingman.secrets.retrieve(name, errors)self.threaded_execution(fn, *a)self.wingman.run_in_thread(fn, *a)await self.local_ai.support(...)await self.wingman.local_ai.generate(...)self.local_ai.remember_fact, …)self.wingman.memory.*(remember/recall/context/ …)await self.wingman.registry.invoke(name, args)await self.wingman.tools.invoke(name, args)→ returns aToolResult(not a 4-tuple)await self.wingman.generate_image(p)await self.wingman.ai.generate_image(p)self.printr.print(...)self.log.info/warning/error(...)Gotchas worth knowing
tts.speak'sinterruptis keyword-only and inverted from the oldno_interrupt(play_to_user(t, True)→tts.speak(t, interrupt=False)).ai.generate(...)returns a string (not a completion object) and is token-capped when conversation condensation is on — pre-summarize bulk text with the freeself.wingman.local_ai.summarize(...).tools.invoke(...)returns aToolResultwith.response/.instant_response/.skill/.label.tts.speak's keyword-only args throughrun_in_thread; wrap it in a smallasync defhelper (see the guide).Migrating with a coding agent?
Point it at MIGRATING-TO-V3.md and say "migrate this skill to the v3 Skill API using this guide." That's exactly how every bundled skill in this PR was ported.
Verify