Skip to content

chore(deps): update rust crate thiserror to v1.0.69#217

Open
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/thiserror-1.x-lockfile
Open

chore(deps): update rust crate thiserror to v1.0.69#217
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/thiserror-1.x-lockfile

chore(deps): update rust crate thiserror to v1.0.69

2a3ceb1
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
GitHub Actions / clippy failed Feb 25, 2026 in 0s

clippy

9 errors, 1 warning

Details

Results

Message level Amount
Internal compiler error 0
Error 9
Warning 1
Note 0
Help 0

Versions

  • rustc 1.93.0 (254b59607 2026-01-19)
  • cargo 1.93.0 (083ac5135 2025-12-15)
  • clippy 0.1.93 (254b59607d 2026-01-19)

Annotations

Check warning on line 169 in src/config/builder/envtrie.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

hiding a lifetime that's elided elsewhere is confusing

warning: hiding a lifetime that's elided elsewhere is confusing
   --> src/config/builder/envtrie.rs:169:23
    |
169 |     fn get_evaluation(&self, envs: &BTreeMap<EnvironmentName, bool>) -> Result<Evaluation, Error> {
    |                       ^^^^^ the lifetime is elided here                        ^^^^^^^^^^ the same lifetime is hidden here
    |
    = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
    = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
help: use `'_` for type paths
    |
169 |     fn get_evaluation(&self, envs: &BTreeMap<EnvironmentName, bool>) -> Result<Evaluation<'_>, Error> {
    |                                                                                          ++++

Check failure on line 55 in src/paths.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator

error: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator
  --> src/paths.rs:55:29
   |
55 |                 if matches!(ret.components().last(), Some(Component::Normal(_))) {
   |                             ^^^^^^^^^^^^^^^^^------
   |                                              |
   |                                              help: try: `next_back()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#double_ended_iterator_last
note: the lint level is defined here
  --> src/lib.rs:23:9
   |
23 | #![deny(clippy::perf)]
   |         ^^^^^^^^^^^^
   = note: `#[deny(clippy::double_ended_iterator_last)]` implied by `#[deny(clippy::perf)]`

Check failure on line 103 in src/config/builder/hoard.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `config::builder::hoard::Error`

error: useless conversion to the same type: `config::builder::hoard::Error`
   --> src/config/builder/hoard.rs:103:66
    |
103 |                 let entry = entry.process_with(envs, exclusivity).map_err(Error::from)?;
    |                                                                  ^^^^^^^^^^^^^^^^^^^^^ help: consider removing
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#useless_conversion
    = note: `#[deny(clippy::useless_conversion)]` implied by `#[deny(clippy::complexity)]`

Check failure on line 78 in src/config/builder/environment/exe.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `map_or` can be simplified

error: this `map_or` can be simplified
  --> src/config/builder/environment/exe.rs:78:33
   |
78 |         let is_lone_file_name = value.parent().map_or(false, |s| s.as_os_str().is_empty());
   |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_map_or
help: use is_some_and instead
   |
78 -         let is_lone_file_name = value.parent().map_or(false, |s| s.as_os_str().is_empty());
78 +         let is_lone_file_name = value.parent().is_some_and(|s| s.as_os_str().is_empty());
   |

Check failure on line 123 in src/command/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `impl` can be derived

error: this `impl` can be derived
   --> src/command/mod.rs:119:1
    |
119 | / impl Default for Command {
120 | |     fn default() -> Self {
121 | |         Self::Validate
122 | |     }
123 | | }
    | |_^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#derivable_impls
help: replace the manual implementation with a derive attribute and mark the default variant
    |
 81 + #[derive(Default)]
 82 | pub enum Command {
 83 |     /// Loads all configuration for validation.
 84 |     /// If the configuration loads and builds, this command succeeds.
 85 ~     #[default]
 86 ~     Validate,
    |

Check failure on line 23 in src/checksum/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `impl` can be derived

error: this `impl` can be derived
  --> src/checksum/mod.rs:19:1
   |
19 | / impl Default for ChecksumType {
20 | |     fn default() -> Self {
21 | |         Self::SHA256
22 | |     }
23 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#derivable_impls
note: the lint level is defined here
  --> src/lib.rs:22:9
   |
22 | #![deny(clippy::complexity)]
   |         ^^^^^^^^^^^^^^^^^^
   = note: `#[deny(clippy::derivable_impls)]` implied by `#[deny(clippy::complexity)]`
help: replace the manual implementation with a derive attribute and mark the default variant
   |
12 + #[derive(Default)]
13 | pub enum ChecksumType {
14 |     /// MD5 checksum -- provided for backwards compatibility with older versions of Hoard.
15 |     MD5,
16 |     /// SHA256 checksum -- currently the default.
17 ~     #[default]
18 ~     SHA256,
   |

Check failure on line 124 in src/checksum/digest.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

non-canonical implementation of `partial_cmp` on an `Ord` type

error: non-canonical implementation of `partial_cmp` on an `Ord` type
   --> src/checksum/digest.rs:116:1
    |
116 | /  impl<T> PartialOrd for Digest<T>
117 | |  where
118 | |      T: Digestable,
119 | |      <<T as Digestable>::OutputSize as Add>::Output: ArrayLength<u8>,
120 | |  {
121 | |      fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
    | | _____________________________________________________________-
122 | ||         Some(self.0.cmp(&other.0))
123 | ||     }
    | ||_____- help: change this to: `{ Some(self.cmp(other)) }`
124 | |  }
    | |__^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#non_canonical_partial_ord_impl
    = note: `#[deny(clippy::non_canonical_partial_ord_impl)]` implied by `#[deny(clippy::all)]`

Check failure on line 164 in src/checkers/history/operation/v2.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `map_or` can be simplified

error: this `map_or` can be simplified
   --> src/checkers/history/operation/v2.rs:162:9
    |
162 | /         self.files
163 | |             .get_pile(pile_name)
164 | |             .map_or(false, |pile| pile.contains_file(rel_path, only_modified))
    | |______________________________________________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_map_or
help: use is_some_and instead
    |
164 -             .map_or(false, |pile| pile.contains_file(rel_path, only_modified))
164 +             .is_some_and(|pile| pile.contains_file(rel_path, only_modified))
    |

Check failure on line 50 in src/checkers/history/operation/v1.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `map_or` can be simplified

error: this `map_or` can be simplified
  --> src/checkers/history/operation/v1.rs:48:55
   |
48 |               (Some(pile_name), Hoard::Named(piles)) => piles
   |  _______________________________________________________^
49 | |                 .get(pile_name)
50 | |                 .map_or(false, |pile| pile.0.contains_key(rel_path)),
   | |____________________________________________________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_map_or
note: the lint level is defined here
  --> src/lib.rs:21:9
   |
21 | #![deny(clippy::style)]
   |         ^^^^^^^^^^^^^
   = note: `#[deny(clippy::unnecessary_map_or)]` implied by `#[deny(clippy::style)]`
help: use is_some_and instead
   |
50 -                 .map_or(false, |pile| pile.0.contains_key(rel_path)),
50 +                 .is_some_and(|pile| pile.0.contains_key(rel_path)),
   |

Check failure on line 24 in src/checkers/history/operation/v2.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

empty line after doc comment

error: empty line after doc comment
  --> src/checkers/history/operation/v2.rs:23:1
   |
23 | / /// Errors that may occur while working with operation logs.
24 | |
   | |_^
...
32 |   pub struct OperationV2 {
   |   ---------------------- the comment documents this struct
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#empty_line_after_doc_comments
note: the lint level is defined here
  --> src/lib.rs:19:9
   |
19 | #![deny(clippy::all)]
   |         ^^^^^^^^^^^
   = note: `#[deny(clippy::empty_line_after_doc_comments)]` implied by `#[deny(clippy::all)]`
   = help: if the empty line is unintentional, remove it
help: if the documentation should include the empty line include it in the comment
   |
24 | ///
   |