Kernel: Add a WaitQueue::wait_until() overload that doesn't need a lock - #26932
Merged
LucasChollet merged 1 commit intoAug 13, 2026
Merged
Conversation
Unlike condition variables, our WaitQueue implementation works correctly without requiring a lock. Users of this overload just need to be sure that the `should_wake` callback is done in an atomic way. See https://read.seas.harvard.edu/cs1610/2026/doc/wait-queues/ (the site we used as an implementation reference) for a good explanation why this is the case, especially the "Synchronization" section. This allows us to remove a dummy spinlock from the WaitQueue in the E1000 driver.
github-actions
Bot
added
the
馃憖 pr-needs-review
LucasChollet
approved these changes
Aug 13, 2026
LucasChollet
left a comment
LucasChollet
left a comment
Member
There was a problem hiding this comment.
Thanks! (And sorry that I forgot to do it myself)
github-actions
Bot
removed
the
馃憖 pr-needs-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike condition variables, our WaitQueue implementation works correctly without requiring a lock. Users of this overload just need to be sure that the
should_wakecallback is done in an atomic way. See https://read.seas.harvard.edu/cs1610/2026/doc/wait-queues/ (the site we used as an implementation reference) for a good explanation why this is the case, especially the "Synchronization" section.This allows us to remove a dummy spinlock from the WaitQueue in the E1000 driver.