skip recording for rsync, scp, and sftp#380
Open
infinet wants to merge 1 commit into
Open
Conversation
Recording rsync, scp, and sftp session can put huge pressure on log storage and slows down file transfer significantly. Detect them and skip recording session. Only record the command executed in the log, e.g. "rsync --server --sender ...".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recording rsync, scp, and sftp session can put huge pressure on log storage and slows down file transfer significantly. Detect them and skip recording session.
Instead of logging file contents transferred via rsync/scp/sftp, the log entry looks like:
..., "out_txt":"rsync --server --sender -vlogDtpre.iLsfxC . ~/src/some.py", ...
..., "out_txt":"rsync --server -vlogDtpre.iLsfxC --partial . /tmp/some.py", ...
..., "out_txt":"scp -t /tmp/some.py","out_bin":[], ...
..., "out_txt":"/usr/libexec/openssh/sftp-server","out_bin":[], ...
It can solve:
#327 Tlog is recording rsync data
#267 Tlog doesn't like WINSCP