feat(session): remove region cache on logout#1217
Merged
Merged
Conversation
SCedricThomas
force-pushed
the
fix/1057/remove-region-cache-on-logout
branch
from
3079c59 to
ef9a118
Compare
EtienneM
force-pushed
the
fix/1057/remove-region-cache-on-logout
branch
from
bad8868 to
41d5469
Compare
EtienneM
force-pushed
the
fix/1057/remove-region-cache-on-logout
branch
2 times, most recently
from
dce8998 to
2c63119
Compare
EtienneM
requested review from
a team,
EtienneM and
matthieu526-scalingo
and removed request for
a team and
EtienneM
matthieu526-scalingo
approved these changes
May 12, 2026
| err = config.DeleteRegionsCache(ctx, config.C) | ||
| if err != nil { | ||
| return errors.Wrap(ctx, err, "remove local regions cache") | ||
| } |
Contributor
There was a problem hiding this comment.
mega-nitpick: missing break line before the return.
Member
There was a problem hiding this comment.
I love this kind of nitpicks 😄
EtienneM
force-pushed
the
fix/1057/remove-region-cache-on-logout
branch
from
2c63119 to
2908779
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How I tested the fix:
scalingo login --password-onlyusing an account with no access to osc-secnum-fr1bscalingo logoutwith the CLI version from this branchbscalingo loginusing an account with access to osc-secnum-fr1bscalingo --app my-test-app --region osc-secnum-fr1 timelineAt this point, the latest release is impacted by a bug which displays:
With the version from this branch, it works with no problem.
fix #1057