Fixes mask editor bug#4024
Merged
Merged
Conversation
jellybean2004
approved these changes
Jul 2, 2026
|
Thank you so much for your quick response and fix! Should I wait until the next release to be able to use this feature? |
Contributor
Author
|
Hi @spowers222, we're finalising what is going to go into the 6.2.0 release at the moment. We're aiming to release this month and we think this will be included but can't say for certain yet. Alternatively, a set of installers for the development version of SasView incorporating this fix are available here: https://github.com/SasView/sasview/actions/runs/28582536880#artifacts |
Member
|
Merging. I will add this to the next pre-release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When setting up radio buttons in the mask editor, the parameter emitted by the
toggledsignal was not accounted for. This PR fixes that.Fixes #4022
How Has This Been Tested?
Ran procedure in #4022, the desired circle now appears on the plot.
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)