Skip to content

Fixes mask editor bug#4024

Merged
jellybean2004 merged 1 commit into
mainfrom
mask_editor_fix
Jul 3, 2026
Merged

Fixes mask editor bug#4024
jellybean2004 merged 1 commit into
mainfrom
mask_editor_fix

Conversation

@DrPaulSharp

Copy link
Copy Markdown
Contributor

Description

When setting up radio buttons in the mask editor, the parameter emitted by the toggled signal was not accounted for. This PR fixes that.

Fixes #4022

How Has This Been Tested?

Ran procedure in #4022, the desired circle now appears on the plot.

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)
    • Wheels installer (GH artifact) has been tested (installed and worked)

Licensing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@spowers222

Copy link
Copy Markdown

Thank you so much for your quick response and fix! Should I wait until the next release to be able to use this feature?

@DrPaulSharp

Copy link
Copy Markdown
Contributor Author

Hi @spowers222, we're finalising what is going to go into the 6.2.0 release at the moment. We're aiming to release this month and we think this will be included but can't say for certain yet. Alternatively, a set of installers for the development version of SasView incorporating this fix are available here: https://github.com/SasView/sasview/actions/runs/28582536880#artifacts

@jellybean2004

Copy link
Copy Markdown
Member

Merging. I will add this to the next pre-release.

@jellybean2004 jellybean2004 merged commit 4ad16db into main Jul 3, 2026
36 checks passed
@jellybean2004 jellybean2004 deleted the mask_editor_fix branch July 3, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mask editor not working

3 participants