Skip to content

Fixes bugs for cloned slicer plots#4021

Open
DrPaulSharp wants to merge 3 commits into
mainfrom
clone_theory_fix
Open

Fixes bugs for cloned slicer plots#4021
DrPaulSharp wants to merge 3 commits into
mainfrom
clone_theory_fix

Conversation

@DrPaulSharp

Copy link
Copy Markdown
Contributor

Description

This PR adds code to the cloneTheory routine to ensure frozen datasets are named as such and hence SasView will not confuse them with the original datasets/plots.

Given the now very close functionality with "Freeze Results" and "Freeze Fit Results", the "Send to Data Explorer" button has been renamed "Freeze Datasets".

Fixes #4018

How Has This Been Tested?

Produced slicer plots a fit of the 2D dataset "SILIC010", used the "Freeze Datasets" button on slicer plots, plotted the new dataset and ensured the new plots did not interfere with the proper slicer plot functionality.

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)
    • Wheels installer (GH artifact) has been tested (installed and worked)

Licensing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@DrPaulSharp DrPaulSharp requested a review from jellybean2004 July 1, 2026 14:03

@jellybean2004 jellybean2004 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested branch rebased on top of #4006 and #4014. Tested functionality, looks sound.

Using the button for non-slicer plots, eg. invariant, size distribution, inversion plots, does have some issues, as lines are turned into scatter plots, but that will be a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues with plots from send to explorer button

2 participants