Handle encoding issues in loading credits.html#4015
Open
llimeht wants to merge 1 commit into
Open
Conversation
krzywon
approved these changes
Jul 1, 2026
krzywon
left a comment
Contributor
There was a problem hiding this comment.
Code looks good. Seems like this should help to fix the issue, but I haven't tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Be defensive against non-UTF-8 chars that can creep into credits.html since it is compiled from lots of different sources, and force use of UTF-8 since the file should already be UTF-8 via
pip-licensesandbuild_tools/compile_licenses.py.This PR
system.legalFixes #4013
How Has This Been Tested?
Tested locally on linux (but note that this is a windows-specific bug due to it still using cp1252):
. .venv/bin/activate python build_tools/compile_licenses.py src/sas/system/credits.html sasviewHave not tested from the installer because generating installer images has been disabled in CI.
Note that unrelated failing test on linux is #4000 which is waiting for PRs to be merged to fix.
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)