Skip to content

Fix ARM64 ADRP page-relative address calculation#576

Open
ada-l0velace wants to merge 1 commit into
SamboyCoding:developmentfrom
ada-l0velace:arm64-adrp-page
Open

Fix ARM64 ADRP page-relative address calculation#576
ada-l0velace wants to merge 1 commit into
SamboyCoding:developmentfrom
ada-l0velace:arm64-adrp-page

Conversation

@ada-l0velace

Copy link
Copy Markdown
Contributor

The incorrect part was ADRP handling: it stored only the page-relative immediate instead of adding the instruction’s page-aligned PC, so folded ARM64 global loads resolved to the wrong address.

Arm64 Documentation:

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 28753900103

Coverage decreased (-0.001%) to 36.138%

Details

  • Coverage decreased (-0.001%) from the base build.
  • Patch coverage: 2 uncovered changes across 1 file (0 of 2 lines covered, 0.0%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
Cpp2IL.Core/InstructionSets/NewArmV8InstructionSet.cs 2 0 0.0%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 12922
Covered Lines: 5053
Line Coverage: 39.1%
Relevant Branches: 8474
Covered Branches: 2679
Branch Coverage: 31.61%
Branches in Coverage %: Yes
Coverage Strength: 166670.53 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants