Avoid loading external plugins from the working directory by default#565
Open
AzusaSaku wants to merge 1 commit into
Open
Avoid loading external plugins from the working directory by default#565AzusaSaku wants to merge 1 commit into
AzusaSaku wants to merge 1 commit into
Conversation
Resolve relative plugin directories from the application base path and add CLI options for explicit plugin loading control.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes external plugin discovery to be application-relative by default instead of depending on the process working directory.
Previously, the default Plugins directory was resolved from Environment.CurrentDirectory. This could be surprising when Cpp2IL is launched from a game directory or another untrusted working directory, since external plugin DLL discovery would then depend on that location. Since external plugins are loaded as .NET assemblies, this avoids accidentally treating the working directory as a plugin trust source.
This PR also adds:
Absolute plugin paths continue to work, and relative plugin paths are resolved from the Cpp2IL application directory.