imageTextBlock: optional square image + host subheading#4783
Draft
isaaclombardssw wants to merge 1 commit into
Draft
imageTextBlock: optional square image + host subheading#4783isaaclombardssw wants to merge 1 commit into
isaaclombardssw wants to merge 1 commit into
Conversation
- New `squareImage` boolean on mediaConfiguration -> crops the image to 1:1 (aspect-square object-cover), off by default. - New `subheading` field on imageTextBlock, rendered uppercase sswRed under the heading. - Apply both to the Mike Smedley host block (square photo; role line moved out of the body into the subheading). Addresses Tiago's design feedback (#13, #14). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
No linked issues found. Please add the corresponding issues in the pull request description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4780
Adds two opt-in, reusable fields to imageTextBlock, from Tiago's feedback on the host (Mike Smedley) section (PR #4760, items #13 + #14):
squareImageboolean onmediaConfiguration; when on, the image is cropped to 1:1 (aspect-square object-cover). Off by default, so no other image changes.subheadingstring on imageTextBlock, rendered uppercase insswRedunder the heading. The host's role line ("SSW · AI Engagement Lead · Melbourne") moves out of the body into it.Both are applied to the host block on the event page.
Stacked on
feature/ai-for-business-leaders-event-page(base), because the host block these enhance lives there — it'll retarget to main once #4760 merges. Schema changed, sotina/tina-lock.jsonis regenerated in this PR.Open decisions for Tiago: square (1:1) vs another portrait ratio for the host photo; subheading styling (currently uppercase sswRed).
Preflight reviewed twice; lint clean; verified rendering on /events/ai-for-business-leaders.