Skip to content

Update PhoneButton padding in MegaMenuLayout#143

Merged
tiagov8 merged 2 commits into
mainfrom
tiagov8-patch-1
Apr 8, 2026
Merged

Update PhoneButton padding in MegaMenuLayout#143
tiagov8 merged 2 commits into
mainfrom
tiagov8-patch-1

Conversation

@tiagov8

@tiagov8 tiagov8 commented Apr 2, 2026

Copy link
Copy Markdown
Member

Improve Contact Us as per @designbyalex

Full width is much better in mobile. The padding seems unconventional. I would expect at least 16px or 1 rem either side

FROM
Screenshot 2026-04-02 at 9 37 22 AM

TO
Screenshot 2026-04-07 at 5 03 55 PM

@tiagov8 tiagov8 requested a review from Calinator444 April 2, 2026 16:37
@tiagov8 tiagov8 enabled auto-merge April 2, 2026 16:51
@designbyalex

Copy link
Copy Markdown
Member

@tiagov8
I'm afraid I was unclear with my padding recommendation

at least 16px or 1 rem either side

My recommendation was under the assumption that the global padding for the page is 16px or 1 rem.
The button should match the rest of the content's padding.

Mobile button conventions: full-width on mobile if there is a single action, or 50/50 width if there are two actions. See examples below.

Screenshot 2026-04-07 at 9 49 55 am

Figure: Facebook mobile app

Screenshot 2026-04-07 at 9 50 06 am

Figure: Audible mobile app

@designbyalex

Copy link
Copy Markdown
Member

@tiagov8
I've realised that the People page on the website has different global padding than the home page.

Screenshot 2026-04-07 at 9 44 57 am

Figure: Look to be ~12px padding

Screenshot 2026-04-07 at 9 45 19 am

Figure: 36 px padding

@tiagov8

tiagov8 commented Apr 7, 2026

Copy link
Copy Markdown
Member Author

cc @griffenedge

Hi @designbyalex

I have updated this PR to also apply the padding to the header area (logo and main menu) + created a new PR to add the same padding to the content area: SSWConsulting/SSW.People#817

I know it is still inconsistent with SSW.com.au (px-4 VS px-8) but I think 36px padding is too much for the people page...

@designbyalex designbyalex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tiagov8 tiagov8 merged commit e9a8490 into main Apr 8, 2026
1 check failed
@tiagov8 tiagov8 deleted the tiagov8-patch-1 branch April 8, 2026 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants