Fix proceeds calculation#2508
Open
alicecoordinator wants to merge 1 commit into
Open
Conversation
A new method `transition_status` was added, to prevent race conditions while two processes try to transition the order status at the same time. With the old implementation, if the payout takes a bit longer, the background job could start new tasks for the same payout, which would cause the order status to go from status 13 to 14 back and forth a few times. Additionally, the compute_proceeds call was moved to later in the process for LN payouts, so that the payout fee is always updated.
alicecoordinator
force-pushed
the
fix-proceeds-calculation
branch
from
3fa702a to
be29298
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new method
transition_statuswas added, to prevent race conditions while two processes try to transition the order status at the same time.With the old implementation, if the payout takes a bit longer, the background job could start new tasks for the same payout, which would cause the order status to go from status 13 to 14 back and forth a few times.
Additionally, the compute_proceeds call was moved to later in the process for LN payouts, so that the payout fee is always updated.
What does this PR do?
Fixes #2447
Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.