Fix ppc64le Clang build: guard intrinsics already defined as builtins#1073
Open
runlevel5 wants to merge 3 commits intoRobertBeckebans:masterfrom
Open
Fix ppc64le Clang build: guard intrinsics already defined as builtins#1073runlevel5 wants to merge 3 commits intoRobertBeckebans:masterfrom
runlevel5 wants to merge 3 commits intoRobertBeckebans:masterfrom
Conversation
On ppc64le, Clang pre-defines __fmadds, __fnmsubs, and __fsels as macros mapping to compiler builtins. Wrap our custom definitions with #ifndef guards so they are skipped when the compiler already provides them. Fixes RobertBeckebans#1042
This codebase intentionally uses memset/memcpy on types that are effectively POD but not technically trivially copyable. Add -Wno-nontrivial-memcall to the Clang warning flags.
runlevel5
force-pushed
the
fix/ppc64le-clang-builtins
branch
from
1bab306 to
0b60e8f
Compare
|
@runlevel5 the conflict comes from the same nontrivial-memcall change I made, which was just merged. I guess we found the same thing! Just revert that commit in your PR and the conflict should disappear. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On ppc64le, Clang pre-defines
__fmadds,__fnmsubs, and__fselsas macros mapping to compiler builtins. Wrap our custom definitions with#ifndefguards so they are skipped when the compiler already provides them.Fixes #1042