Skip to content

Issue 2615: retrieve Application list by FriendlyName#2678

Open
ddhuy wants to merge 6493 commits into
RestComm:masterfrom
ddhuy:issue_2615_ddhuy
Open

Issue 2615: retrieve Application list by FriendlyName#2678
ddhuy wants to merge 6493 commits into
RestComm:masterfrom
ddhuy:issue_2615_ddhuy

Conversation

@ddhuy

@ddhuy ddhuy commented Nov 30, 2017

Copy link
Copy Markdown

Add application filters in DAO layers

Fernando Mendioroz and others added 30 commits October 20, 2017 03:26
… and SMS API, GMLC, USSD Gateway and SIP Phone
Create a simple emergency location based service.adoc added
…ns, tested s3 upload with this version and its working like a charm
…PI_MySQL_error

Critical fix for making Geolocation API work with RC running on MySQL
build.xml will fetch RVD from github/releases instead of mobicents

Refers RestComm#2598
…configuration

Addition of http-client configuration params for HTTP conn pooling
Home, Accounts, Sub-Accounts, Analytics and Clients pages already changed
@ddhuy ddhuy mentioned this pull request Nov 30, 2017
@ddhuy

ddhuy commented Nov 30, 2017

Copy link
Copy Markdown
Author

@gsaslis , Please can you help review this fix

@ddhuy ddhuy changed the title Issue 2615 Issue 2615: retrieve Application FriendlyName Nov 30, 2017
@ddhuy ddhuy changed the title Issue 2615: retrieve Application FriendlyName Issue 2615: retrieve Application list by FriendlyName Nov 30, 2017

@gsaslis gsaslis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ddhuy,

Would you kindly add some tests around the new functionality you are introducing with this PR?

Take a look here for some ideas on how to approach writing these tests

@ddhuy

ddhuy commented Dec 15, 2017

Copy link
Copy Markdown
Author

@gsaslis , Thanks for your comments. I have just add new tests for the new functionality and fix some old test problems.

@gsaslis

gsaslis commented Jan 25, 2018

Copy link
Copy Markdown
Contributor

Thanks @ddhuy and apologies for the delayed response here.

Will request review from core team.

@gsaslis gsaslis requested review from a team and removed request for ghjansen, gvagenas and maria-farooq February 9, 2018 11:10
@gvagenas gvagenas force-pushed the master branch 2 times, most recently from 9469191 to c67f142 Compare January 13, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet