[avr-hal-generic] remove rustc version check#619
Merged
Conversation
Contributor
|
Make it two separate merge requests and give both commits good commit messages. |
The build.rs logic is only used to detect a relatively old compiler version (Feb 2022). Since a nightly build is required to target AVR it's unlikely anyone is benefiting from this check. By removing it we reduce dependencies and implementation complexity.
tones111
force-pushed
the
no_rustversion
branch
from
9e5fdd6 to
6fa0d2d
Compare
Contributor
Author
|
As requested, I've updated the commit message to more clearly describe the motivation and split the dependent change into #624 (but I think that makes the review more complicated due to GitHub's lack of support for dependent reviews). |
Rahix
approved these changes
Jan 4, 2025
Owner
Rahix
left a comment
Rahix
left a comment
There was a problem hiding this comment.
Fair enough, I think we no longer need to keep this back-compat code here. Users of current versions of avr-hal will be on more recent compilers I would assume. If not, we can add it back in when someone complains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AVR compilation requires a nightly compiler so it's unlikely users are still on a pre-1.59 version (Feb 2022).