Add plastic wall for HYDRA#1335
Conversation
mduer
force-pushed
the
hydra_pw
branch
3 times, most recently
from
2bcba23 to
c73cd70
Compare
|
Pass all checks |
mduer
force-pushed
the
hydra_pw
branch
3 times, most recently
from
492452a to
39a9cb9
Compare
|
After adding your name to the Author list, you must run the python scripts: |
I get errors for both when running them with python3 xx.. in thr R3BRoot folder. Do I need to do something in addition? |
| #include "FairMultiLinkedData.h" | ||
| #include "TObject.h" | ||
|
|
||
| class R3BPWPreCalData : public FairMultiLinkedData |
There was a problem hiding this comment.
Here you don't need FairMultiLinkedData, just
class R3BPWPreCalData : public TObject
|
|
||
| #include "FairMultiLinkedData.h" | ||
|
|
||
| class R3BPWHitData : public FairMultiLinkedData |
There was a problem hiding this comment.
Here you don't need FairMultiLinkedData, just
class R3BPWHitData : public TObject
| [[nodiscard]] double GetTot0() const { return fTot0; } | ||
| [[nodiscard]] double GetTot1() const { return fTot1; } | ||
|
|
||
| protected: |
There was a problem hiding this comment.
private: instead of protected:
| inline void SetTime(double time) { fTime = time; } | ||
| inline void SetCharge(double Q) { fCharge = Q; } | ||
|
|
||
| protected: |
There was a problem hiding this comment.
private: instead of protected:
| [[nodiscard]] UShort_t GetEdge() const { return fEdge; } | ||
| [[nodiscard]] uint64_t GetEpoch() const { return fEpoch; } | ||
|
|
||
| protected: |
There was a problem hiding this comment.
private: instead of protected:
| [[nodiscard]] double GetTime() const { return fTime; } | ||
| [[nodiscard]] double GetTot() const { return fTot; } | ||
|
|
||
| protected: |
There was a problem hiding this comment.
private: instead of protected:
| #include "FairMultiLinkedData.h" | ||
| #include "TObject.h" | ||
|
|
||
| class R3BPWCalData : public FairMultiLinkedData |
There was a problem hiding this comment.
Here you don't need FairMultiLinkedData, just
class R3BPWCalData : public TObject
|
|
||
| #pragma once | ||
|
|
||
| #include "FairMultiLinkedData.h" |
There was a problem hiding this comment.
remove #include "FairMultiLinkedData.h"
| #pragma once | ||
|
|
||
| #include "FairMultiLinkedData.h" | ||
| #include "TObject.h" |
There was a problem hiding this comment.
add also #include "Rtypes.h"
| explicit R3BPWCalData(UShort_t DetId, UShort_t Bar, double Time0, double Time1, double Tot0, double Tot1); | ||
|
|
||
| /** Destructor **/ | ||
| virtual ~R3BPWCalData() = default; |
There was a problem hiding this comment.
~R3BPWCalData() override = default;
2 participants
Add plastic wall for HYDRA
Checklist:
devbranch