Skip to content

feat(input): move physical cursor to visual cursor for IME input #4652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pomelo-nwu merged 10 commits into from
Jun 3, 2026
Merged

feat(input): move physical cursor to visual cursor for IME input #4652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
78bd923
feat(input): add useCursor hook for IME physical cursor tracking
zzhenyao May 29, 2026
55890eb
refactor(input): optimize cursor positioning effect
zzhenyao May 29, 2026
544281e
feat(input): move setCursorPosition to render phase for immediate cur…
zzhenyao May 29, 2026
454f904
fix(input): calculate absolute cursor position by walking yoga tree
zzhenyao May 30, 2026
51d83aa
fix(input): use addLayoutListener instead of useCursor for zero-jitte…
zzhenyao May 30, 2026
1325467
perf(input): stable addLayoutListener subscription and skip redundant…
zzhenyao May 31, 2026
13a4380
fix(input): revert lastPos dedup that broke cursorDirty one-shot flag
zzhenyao May 31, 2026
975d302
Merge branch 'fix-ink-cursor-ime' into fix-ink-cursor-ime-v2
zzhenyao May 31, 2026
886004e
feat(input): use patch-package to expose Ink internals for IME cursor…
zzhenyao May 31, 2026
d2548cf
fix(input): address review feedback — prefixWidth, remove useBoxMetri…
zzhenyao May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
195 changes: 195 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
"build:sdk:python": "python3 -m build packages/sdk-python",
"check-i18n": "npm run check-i18n --workspace=packages/cli",
"preflight": "npm run clean && npm ci && npm run format && npm run lint:ci && npm run build && npm run typecheck && npm run test:ci",
"postinstall": "patch-package",
Copy link
Copy Markdown
Collaborator

@wenshao wenshao May 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] patch-package is added as a postinstall hook to apply patches/ink+7.0.3.patch, but ink is declared as "^7.0.3" (caret range). If npm resolves a newer Ink version (e.g. 7.0.4), patch-package will refuse to apply the patch because the filename is version-pinned to 7.0.3. The imports from 'ink/dom' and from 'ink/components/CursorContext' would then fail at runtime with ERR_PACKAGE_PATH_NOT_EXPORTED.

While the lockfile mitigates this in practice, consider pinning Ink to the exact version to make the coupling explicit:

"ink": "7.0.3"

— qwen3.7-max via Qwen Code /review

"prepare": "husky && npm run build && npm run bundle",
"prepare:package": "node scripts/prepare-package.js",
"package:hosted-installation": "node scripts/build-hosted-installation-assets.js",
Expand Down Expand Up @@ -126,6 +127,7 @@
"mock-fs": "^5.5.0",
"msw": "^2.10.4",
"npm-run-all": "^4.1.5",
"patch-package": "^8.0.1",
"prettier": "^3.5.3",
"react-devtools-core": "^6.1.5",
"semver": "^7.7.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"fzf": "^0.5.2",
"glob": "^10.5.0",
"highlight.js": "^11.11.1",
"ink": "^7.0.3",
"ink": "7.0.3",
"ink-gradient": "^3.0.0",
"ink-link": "^4.1.0",
"ink-spinner": "^5.0.0",
Expand Down
Loading
Loading