feat(luau): convert 41 trivial files to --!strict typing - #671
Merged
Conversation
Deploy Results
1 deployed, 1 passed, 0 failed in 37.6s · View logs Test Results
14 tested, 14 passed, 0 failed in 27.0s · View logs |
Convert small, simple Luau files from --!nonstrict to --!strict. These are files with straightforward patterns (constants, TieDefinition interfaces, BinderProvider registrations, factory returns, and simple utility functions) where strict mode requires no structural changes. Files needing type annotations (KinematicUtils, IKRigUtils, TeamKillTrackerUtils, PlayerKillTrackerUtils, RoguePropertyBaseValueTypeUtils) received explicit parameter and return type annotations. https://claude.ai/code/session_01BXcv4dUAUw7hWPE5F5nRPL
Quenty
force-pushed
the
claude/luau-strict-typing-9CjQp
branch
from
February 28, 2026 04:03
d516d27 to
0edcac1
Compare
The test/modules files (TestInputKeyMap, OpenableInterface, ActionInterface) cannot resolve script.Parent.loader from the root sourcemap, so strict mode produces "Unknown require" errors. All existing test/modules files use --!nonstrict. BodyColorsDataConstants and the two gameproductservice interfaces leak strict types to downstream consumers (BodyColorsDataUtils, GameProductDataService, GameProductService), which fail with iteration and TieDefinition type-inference errors.
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts 32 simple Luau files (constants, TieDefinition interfaces, BinderProvider registrations, factory returns, and small utilities) from --!nonstrict to --!strict, with explicit type annotations added to KinematicUtils, IKRigUtils, TeamKillTrackerUtils, PlayerKillTrackerUtils, and RoguePropertyBaseValueTypeUtils where needed. A follow-up revert keeps six files at --!nonstrict: three test/modules files where script.Parent.loader cannot be resolved from the root sourcemap, and three (BodyColorsDataConstants and the two gameproductservice interface modules) whose strict types broke already-strict downstream consumers.