enforcing or not relax_cell in elastic tensor flow#2735
Draft
lbluque wants to merge 2 commits into
Draft
Conversation
Collaborator
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Following up on the conversation from #2733 (comment). Closes #2897.
I removed the explicit
relax_cell=Truefrom the first relaxation in theelastic_tensor_flow. @Andrew-S-Rosen happy to make any edits in this PR so either inform users edit the code in any way.Requirements
main).Note: If you are an external contributor, you will see a comment from @buildbot-princeton. This is solely for the maintainers.