fix: Correctly handle min and max bounds less than 1 for Decimal#131
Merged
Oliver Borchert (borchero) merged 1 commit intoQuantco:mainfrom Sep 4, 2025
jhall-bp:decimal-validation
Merged
fix: Correctly handle min and max bounds less than 1 for Decimal#131Oliver Borchert (borchero) merged 1 commit intoQuantco:mainfrom jhall-bp:decimal-validation
Oliver Borchert (borchero) merged 1 commit intoQuantco:mainfrom
jhall-bp:decimal-validation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 2450 2451 +1
=========================================
+ Hits 2450 2451 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Oliver Borchert (borchero)
approved these changes
Sep 4, 2025
Member
Oliver Borchert (borchero)
left a comment
There was a problem hiding this comment.
LGTM, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Issue: #130
dy.Decimalcurrently crashes during validation when instantiated with a min or max value that is 0 or less. This PR changes the way that the number of digits before the decimal place of adecimal.Decimalis calculated so that smaller mix/max values can be used as constraints.Changes
dy.Decimalinputs has been changed to use the digits and exponent values fromdecimal.Decimal.as_tuple()to calculate the number of digits instead of usingmath.log10dy.Decimal