refactor: Move IO specifics out of Schema, Collection#109
Merged
Andreas Albert (AndreasAlbertQC) merged 27 commits intomainfrom Aug 29, 2025
Merged
refactor: Move IO specifics out of Schema, Collection#109Andreas Albert (AndreasAlbertQC) merged 27 commits intomainfrom
Schema, Collection#109Andreas Albert (AndreasAlbertQC) merged 27 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 42 45 +3
Lines 2450 2573 +123
==========================================
+ Hits 2450 2573 +123 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
Member
Oliver Borchert (borchero)
left a comment
There was a problem hiding this comment.
Just some cosmetic comments, thanks! 🚀
Collaborator
Author
|
Thanks Oliver Borchert (@borchero)! While refactoring into multiple files, I realized I had completely missed that |
Oliver Borchert (borchero)
approved these changes
Aug 28, 2025
Member
Oliver Borchert (borchero)
left a comment
There was a problem hiding this comment.
Let's go :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current implementation of parquet-based storage is strongly coupled to the implementation of the
SchemaandCollectionclasses. This makes it hard to reuse parts of the logic that would also be useful for other future storage backends. To prepare the implementation of such future storage backends, this PR refactors the current logic to introduce a clearer interface for storage backends.Changes
StorageBackend, i.e. a piece of code encapsulating a way of storing data and metadata.StorageBackendinterface