Remove references to defunct git_ignore config#2531
Conversation
It raises `UnsupportedSettings` because e168069 removed it without removing the documentation that refers to it. The remaining config option that still works is `skip_gitignore`.
|
It's true that |
|
I think the real question is whether So I think this PR probably does all of the documentation changes that we want related to this - perhaps a separate ticket is warranted for whether |
|
Makes a lot of sense 😁 I never read the code other than the commit you passed and there I just saw that it was a replacement so I assumed is similar funtionality, different flag. But yeah, if the functionality is different, then all good 🥳 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2531 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 41 41
Lines 3090 3090
Branches 668 668
=======================================
Hits 3064 3064
Misses 14 14
Partials 12 12 🚀 New features to boost your workflow:
|
https://pycqa.github.io/isort/docs/configuration/options.html#git-ignore is nonsense and doesn't work - it raises
UnsupportedSettingsbecause e168069 removed it without removing the documentation that refers to it.The remaining config option that still works is
skip_gitignorehttps://pycqa.github.io/isort/docs/configuration/options.html#skip-gitignore.Remove the defunct one to avoid confusion.
Fixes #1920