Avoid UnicodeEncodeError on narrow-encoding output streams (#1251)#1406
Open
DotChas wants to merge 2 commits intoPyCQA:mainfrom
Open
Avoid UnicodeEncodeError on narrow-encoding output streams (#1251)#1406DotChas wants to merge 2 commits intoPyCQA:mainfrom
DotChas wants to merge 2 commits intoPyCQA:mainfrom
Conversation
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I fixed #1251
I was looking through the codebase and noticed Bandit can crash with a
UnicodeEncodeErrorwhen writing reports to output streams using a narrow encoding (for example GBK in some Windows/pre-commit environments).This PR adds a small wrapper around the output stream so unencodable characters are emitted as backslash-escape sequences (e.g.
\U0001f31f) instead of raising and aborting the run.Note: This PR focuses only on making report output robust against narrow encodings. It does not change any formatter output content/structure beyond escaping characters that cannot be represented by the target encoding.
Tests:
tox -e py310Thanks,
Cevdet Samed / DotChas