Fix exit code for invalid scan targets (#1326)#1402
Open
soh2970 wants to merge 3 commits intoPyCQA:mainfrom
Open
Fix exit code for invalid scan targets (#1326)#1402soh2970 wants to merge 3 commits intoPyCQA:mainfrom
soh2970 wants to merge 3 commits intoPyCQA:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1326
Bandit previously returned exit code 0 when scan targets were invalid (ie. nonexistent directories), even though files were skipped due to errors. This could cause silent failures in CI/CD pipelines.
This change updates the CLI exit logic to return a non zero exit code when scan targets are invalid.
Tests were updated to reflect the corrected behavior, and a functional test was adjusted to expect a non zero exit code for nonexistent paths.
Behavior after fix: