Fix: wire up --verbose flag to gate PASS output in validate.py#898
Open
jcarr710 wants to merge 2 commits into
Open
Fix: wire up --verbose flag to gate PASS output in validate.py#898jcarr710 wants to merge 2 commits into
jcarr710 wants to merge 2 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The
--verboseflag was defined in argparse but never passed throughto
validate_directoryorvalidate_files_in_directory, so it hadno effect regardless of whether it was passed or not.
This fix wires
verbosethrough the call chain so that PASS outputis only shown when
--verboseis passed. Default behavior now showsonly failures and the summary, which is more useful when validating
500+ files.
Before: python scripts/validate.py always printed all PASS lines
After: python scripts/validate.py shows summary only
python scripts/validate.py --verbose shows all PASS lines