measure difference of silent and non-silent processing#468
Closed
hendriktews wants to merge 1 commit into
Closed
Conversation
Contributor
|
Hi @hendriktews ! just a minor remark regarding this new feature of GitHub PRs (but maybe you're already aware of it): we can create − or convert, see screenshot below − PRs in "draft mode" to automatically tag them as not-to-be-merged-yet.
|
erikmd
changed the title
Contributor
|
@hendriktews just FYI I converted this PR in "draft mode" as I had proposed in my previous comment |
Collaborator
Author
|
Erik Martin-Dorel <notifications@github.com> writes:
@hendriktews just FYI I converted this PR in "draft mode" as I had proposed in my previous comment
The discussion in PR #467 has concluded some time ago already
that silent mode is preferred. Therefore we should abandon this
PR.
|
Contributor
OK so closing that PR, thanks @hendriktews |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are just two lines for measuring how long it takes to assert a block. The numbers show up in the Messages buffer. To see the difference between silent and non-silent processing, do it twice with and without proof-full-annotation set (also available in menu PG->Quick Options->Processing->Full Annotation).
I see 10.7 seconds for silent and 10.9 seconds for ≈3000 lines, without loading required modules.