-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add spatial shape constraint docs and validation for DiNTS (#6771) #8827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+64
−4
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
88ce791
Add spatial shape constraint docs and validation for DiNTS (#6771)
Cado87 c0cc47a
Merge branch 'dev' into docs/dints-shape-constraints
Cado87 3420a85
Fix TorchScript compatibility and invalid test input shape for DiNTS
Cado87 214ab53
Merge branch 'dev' into docs/dints-shape-constraints
Cado87 973662b
Unify use_downsample source in DiNTS to avoid inconsistent validation
Cado87 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: Project-MONAI/MONAI
Length of output: 1924
🏁 Script executed:
Repository: Project-MONAI/MONAI
Length of output: 1042
🏁 Script executed:
Repository: Project-MONAI/MONAI
Length of output: 993
🏁 Script executed:
Repository: Project-MONAI/MONAI
Length of output: 597
🏁 Script executed:
Repository: Project-MONAI/MONAI
Length of output: 1833
🏁 Script executed:
Repository: Project-MONAI/MONAI
Length of output: 692
Test case dimensions incompatible with new validation. The cuda case (lines 47-67 in test file) uses
num_depths=4, use_downsample=Truewith shape(3, 2, 32, 32, 16). The validation requires all spatial dims divisible by2^(4+1)=32, but16 % 32 ≠ 0. During normal test execution, the guard does not skip the check, sotest_dints_inferenceandtest_dints_searchwill fail withValueError. Update the spatial dimension to 32 or replace with a compatible test case.🤖 Prompt for AI Agents