chore: revert reject unsupported task system_prompt - #1769
Closed
mikasenghaas wants to merge 1 commit into
Closed
Conversation
This reverts commit cc4afd5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanly reverts #1735 ("fix: reject unsupported task system_prompt"), restoring the prior
Harness.resolve_promptbehavior:APPENDS_SYSTEM_PROMPT(e.g.codex/kimi_code/mini_swe_agent) once again foldstask.system_promptinto the user prompt ("{system}\n\n{prompt}", with a warning) instead of raising aValueError.APPENDS_SYSTEM_PROMPTharnesses (default/bash/rlm) are unaffected — the system prompt is still emitted separately.APPENDS_SYSTEM_PROMPT,resolve_prompt, andTask.system_prompt.Produced with
git revert cc4afd52(the #1735 squash-merge); a clean inverse with no manual edits. The latersetupmethod and boundary-error changes (#1749 / #1751) are untouched.Breaking
system_prompton a non-APPENDS_SYSTEM_PROMPTharness no longer error — they fold the system prompt into the user message (with a warning) as before.Note
Revert rejection of tasks with unsupported system prompts in
Harness.resolve_promptAPPENDS_SYSTEM_PROMPT=False) and the prompt is a plain string,resolve_promptnow logs a warning and prepends the system prompt to the user prompt instead of raising an error.ValueErroris still raised when the prompt isMessagesorNoneand a system prompt is provided, as folding is not possible in those cases.Task.system_promptfield docs in task.py to reflect the new prepend-with-warning behavior.Macroscope summarized 2bccead.