improvement: drop jobId from hosted training run response#756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
job_id/jobIdfromHostedTrainingRunResponseand theprime rldispatch surface (JSON output and human print).job_idis a platform-internal scheduling id; the backend is dropping it fromPOST /api/v1/training/runsso clients can't infer the cluster from it.run_idandtoken_valueremain.Note
Low Risk
Narrow CLI/API contract change for a beta-gated endpoint; automation that parsed
jobIdfrom dispatch JSON would break, butrunIdremains.Overview
Aligns the Prime CLI with the backend removing
jobIdfromPOST /v1/training/runs, so clients no longer see the platform-internal scheduling id (which could leak cluster inference).HostedTrainingRunResponseno longer parsesjob_id;run_idandtoken_valueare unchanged (andtoken_valueis still withheld from stdout/JSON on dispatch).Full-FT dispatch via
_dispatch_full_finetune_runnow returns JSON{"run": {"runId": ...}}only and prints a single Dispatched line withrun_id, without the job id suffix.Reviewed by Cursor Bugbot for commit 1ff0c1f. Bugbot is set up for automated code reviews on this repo. Configure here.