add run-as-user support to container sandbox exec#743
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d3b3e82e4e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
JannikSt
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes command execution identity in sandboxes; incorrect
uservalues or gateway handling could affect permissions or security boundaries, though VM sandboxes are explicitly guarded.Overview
Adds optional run-as-user support for executing commands in container sandboxes (similar to
docker exec -u), wired through the SDK and CLI.CommandRequestgains an optionaluserfield. Sync and asyncexecute_commandacceptuserand, for container sandboxes, include it in the gateway/execJSON payload when set. VM sandboxes reject a non-nulluserwithValueError(Connect RPC path unchanged).start_background_jobalso acceptsuserand passes it through to the bootstrapexecute_commandcall.prime sandbox runexposes-u/--userand forwards it toexecute_command, with console output when specified.Reviewed by Cursor Bugbot for commit 1e03765. Bugbot is set up for automated code reviews on this repo. Configure here.