remove: deprecated JSPath DSL for jwt-role-claim-key config - #5192
remove: deprecated JSPath DSL for jwt-role-claim-key config#5192taimoorzaeem wants to merge 1 commit into
Conversation
This reverts commit 4834678. The deprecation is now removed in favor of the new JSONPath syntax and it will take effect in the next major version.
169e7fc to
f52f5dd
Compare
taimoorzaeem
changed the title
steve-chavez
left a comment
steve-chavez
left a comment
There was a problem hiding this comment.
See my reasoning on #5171 (comment). I'm not at all driven to break backcompat just for the sake of it, there must be a justification like: it's hard to add a new feature (if demanded) for this code path.
wolfgangwalther
left a comment
wolfgangwalther
left a comment
There was a problem hiding this comment.
Assuming the remainder is a straight revert, I only looked at the changelog part. LGTM.
Wow, wait a minute. The deprecation policy was introduced to allow us to make breaking changes. If you're now arguing that we shouldn't make them, then we have not gained anything. In this case, I am taking back my approval on the policy. |
3 participants
This reverts #5171.
The deprecation is now removed in favor of the new JSONPath syntax and it will take effect in the next major version.