test: move schema cache observation tests to io tests - #5169
Open
taimoorzaeem wants to merge 2 commits into
Open
test: move schema cache observation tests to io tests#5169taimoorzaeem wants to merge 2 commits into
taimoorzaeem wants to merge 2 commits into
Conversation
It's better to separate them so the config is tested in isolation. Signed-off-by: Taimoor Zaeem <taimoorzaeem@gmail.com>
Gradually moving towards PostgREST#4868, where we agreed on removing observability test-suite and merge its tests in io-tests suite. Signed-off-by: Taimoor Zaeem <taimoorzaeem@gmail.com>
Collaborator
I am not really convinced we should get rid of Haskell tests - I find them very useful to pinpoint issues as they test pieces of finer granularity. Secondly, That's my personal take on it though and it is up to @wolfgangwalther and @steve-chavez to decide. |
mkleczek
reviewed
Aug 18, 2026
| assert any(pool_flushed_obs in line for line in output) | ||
| assert any(re.search(schema_cache_queried_in_obs, line) for line in output) | ||
| assert any(re.search(schema_cache_loaded_obs, line) for line in output) | ||
| assert any(re.search(schema_cache_loaded_in_obs, line) for line in output) |
Collaborator
There was a problem hiding this comment.
That does not validate of operations ordering.
| sleep_until_postgrest_config_reload() | ||
|
|
||
| # reload schema cache to verify that the config reload actually happened | ||
| postgrest.process.send_signal(signal.SIGUSR1) |
Collaborator
There was a problem hiding this comment.
Schema cache reloading also reloads configuration
| assert any(pool_flushed_obs in line for line in output) | ||
| assert any(re.search(schema_cache_queried_in_obs, line) for line in output) | ||
| assert any(re.search(schema_cache_loaded_obs, line) for line in output) | ||
| assert any(re.search(schema_cache_loaded_in_obs, line) for line in output) |
Collaborator
There was a problem hiding this comment.
Ditto (no ordering validation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gradually moving towards #4868, where we agreed on removing observability test-suite and merge its tests in io-tests suite.