Skip to content

fix(patchesAppliedIndication): defer findBoxComponent lookup to PATCH 3 #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
risenowrise wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(patchesAppliedIndication): defer findBoxComponent lookup to PATCH 3 #713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions src/patches/patchesAppliedIndication.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,14 +475,6 @@ export const writePatchesAppliedIndication = (
return null;
}

const boxComponent = findBoxComponent(fileContents);
if (!boxComponent) {
console.error(
'patch: patchesAppliedIndication: failed to find Box component'
);
return null;
}

// PATCH 2: Add tweakcc version to all header paths.
// Path A: SyK banner borderText (chalk template literal)
// Path B: SyK compact borderText (chalk call)
Expand Down Expand Up @@ -551,6 +543,13 @@ export const writePatchesAppliedIndication = (

// PATCH 3: Add patches applied list (if enabled)
if (showPatchesApplied) {
const boxComponent = findBoxComponent(content);
if (!boxComponent) {
console.error(
'patch: patchesAppliedIndication: PATCH 3 skipped (Box component not located on this CC version)'
);
return content;
}
const patchesListLoc = findPatchesListLocation(content);
if (!patchesListLoc) {
console.error(
Expand Down