Fix checkpoint directory race condition in DDP training#969
Open
0xadvait wants to merge 1 commit into
Open
Conversation
With torchrun and --overwrite, every rank deleted and recreated the checkpoint directory simultaneously, so ranks could crash with FileNotFoundError when another rank removed the directory first. Only the main process now performs the rmtree and mkdir, and all ranks synchronize on a barrier before training continues. Fixes Physical-Intelligence#868
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Multi-GPU training with torchrun and
--overwritecrashes intermittently: every rank executes the checkpoint-directory setup intrain_loop, so all ranks callshutil.rmtreeon the same directory at once, and ranks that lose the race die withFileNotFoundError(full traceback in #868).Fix
--overwrite) and creates the checkpoint directory.dist.barrier()after directory setup, so no rank proceeds before the directory state is settled.Verification
ruff checkandruff format --checkpass.FileNotFoundError140 times across 20 attempts, the guarded pattern produced 0 errors across 50 attempts.save_checkpointalready guards onis_main, so no other rank-unsafe filesystem operations remain in the script.Fixes #868