feat: mark deprecated classes and methods for future removal#1417
Merged
feat: mark deprecated classes and methods for future removal#1417
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR marks a set of legacy APIs across Essentials/Core as deprecated by adding [Obsolete] attributes (and a few small formatting/tidy changes), helping steer developers away from unsupported components ahead of future removal.
Changes:
- Added
[Obsolete]attributes to selected classes/interfaces/methods/enum members across multiple projects. - Deprecated specific device/routing/logging-related APIs (e.g.,
CameraVisca,eRoutingSignalTypemembers,ILogStrings*,DebugContext). - Minor whitespace/formatting updates in touched files (notably
ConfigUpdaterandWebApiPasscodeClient).
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/PepperDash.Essentials/ControlSystem.cs | Marks LoadLogoServer as obsolete. |
| src/PepperDash.Essentials.MobileControl.Messengers/Messengers/DeviceStateMessageBase.cs | Marks SetInterfaces as obsolete and adds using System;. |
| src/PepperDash.Essentials.Devices.Common/Cameras/CameraVisca.cs | Marks CameraVisca as obsolete in favor of plugin usage. |
| src/PepperDash.Essentials.Core/Routing/eRoutingSignalType.cs | Marks several enum members as obsolete. |
| src/PepperDash.Essentials.Core/Interfaces/ILogStringsWithLevel.cs | Marks ILogStringsWithLevel as obsolete and formats signature spacing. |
| src/PepperDash.Essentials.Core/Interfaces/ILogStrings.cs | Marks ILogStrings as obsolete. |
| src/PepperDash.Essentials.Core/Config/Essentials/ConfigUpdater.cs | Marks ConfigUpdater as obsolete; formatting changes also surfaced a null-check logic bug. |
| src/PepperDash.Core/WebApi/Presets/WebApiPasscodeClient.cs | Marks class as obsolete; formatting changes surfaced unprofessional comment and event-invocation race pattern. |
| src/PepperDash.Core/Logging/DebugContext.cs | Marks DebugContext as obsolete. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
andrew-welker
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds
[Obsolete]attributes to several classes, interfaces, methods, and enum members across the codebase. The purpose is to mark these components as deprecated, indicating they are no longer supported and will be removed in a future release. This helps developers avoid using outdated code and prepares the codebase for future clean-up.Deprecation of core classes and interfaces:
DebugContext,WebApiPasscodeClient, and the static classConfigUpdateras obsolete, signaling that these classes are no longer supported and will be removed in a future release. [1] [2] [3]ILogStringsandILogStringsWithLevelas obsolete. [1] [2]Deprecation of device and camera-related components:
CameraViscaclass as obsolete, instructing users to use the CameraVisca plugin instead.Deprecation of routing signal types:
UsbOutput,UsbInput, andSecondaryAudiomembers of theeRoutingSignalTypeenum as obsolete.Deprecation of methods:
SetInterfacesmethod inDeviceStateMessageBaseand theLoadLogoServermethod as obsolete, providing guidance on alternative approaches. [1] [2]