-
Notifications
You must be signed in to change notification settings - Fork 708
feat: Compute gMSA AES keys when using --gmsa #1125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d818235
Enhancement : Compute gMSA aesKeys automatically when using --gmsa
fa7706b
Factorize code
696cfdf
Merge branch 'main' into main
NeffIsBack f5bbf07
Use generate_kerberos_keys
NeffIsBack 4951135
Remove unused import
NeffIsBack 48691de
Functionalize key generation
NeffIsBack 324ff9e
Remove unused import
NeffIsBack d022f14
Formatting
NeffIsBack 21ea460
Remove duplicate search base
NeffIsBack 178df41
Switch order of displaying kerberos keys
NeffIsBack 3580522
If we don't have a sAMAccountName skip kerberos keys
NeffIsBack 8d5c81c
Formatting
NeffIsBack a0c62e2
Formatting
NeffIsBack d9603d5
Formatting
NeffIsBack 028e774
Formatting
NeffIsBack d8ea63d
Add error message if gmsa string is invalid
NeffIsBack a23d0fa
Pythonic
NeffIsBack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.