Add validation message for 'real name' field (#477)#719
Open
19AnastasiaTsareva20 wants to merge 2 commits into
Open
Add validation message for 'real name' field (#477)#71919AnastasiaTsareva20 wants to merge 2 commits into
19AnastasiaTsareva20 wants to merge 2 commits into
Conversation
klimashkin
previously approved these changes
Apr 18, 2025
kabalin
requested changes
Apr 18, 2025
Member
kabalin
left a comment
There was a problem hiding this comment.
Hi, thanks for PR, it is a good start! The real name strings actually exist already in the schema. But adding validation is not sufficient, validation output needs to be passed to client and displayed as error when saving the form.
Please include the screenshot how the error looks like in the UI.
| lastName: { type: String }, | ||
| disp: { type: String }, // Display name | ||
|
|
||
| realName: { |
Author
|
I have made some changes to this update request using a different approach to solving the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #477
Problem Description
After further investigating issue #477 with displaying long text in user profiles, I discovered that the problem cannot be fully solved by simply adding field validation. Even with validation, long text can still distort the UI due to CSS and HTML limitations for disabled input fields.
Proposed Solution
Instead of limiting text length through validation (which restricts users), I developed a CSS solution that improves the display of any text regardless of its length:
Changes
Modified
views/module/user/profile.pugto use div containers in view mode