You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Make it easier for users to provide us the full version string when asked to in support channels, if they're running the command in game instead of in console.
This is not an issue with this PR per-se, but there are no migrations in place for messages.properties or any similar file for a different languages. Updating velocity without removing messages.properties or manually adding this key will make the hover text show up as the translation key. Is this something that should be considered in the future? Message files migrations for adding keys, just like there's a migration system in-place for velocity.toml?
This is not an issue with this PR per-se, but there are no migrations in place for messages.properties or any similar file for a different languages. Updating velocity without removing messages.properties or manually adding this key will make the hover text show up as the translation key. Is this something that should be considered in the future? Message files migrations for adding keys, just like there's a migration system in-place for velocity.toml?
This problem also came to my attention when working on this pr. However, solving it is way out of scope of this pr and should be discussed in a separate issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it easier for users to provide us the full version string when asked to in support channels, if they're running the command in game instead of in console.