Skip to content

Fix username duplication in chat when defaultRenderer is explicitly set #13868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Axyss wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix username duplication in chat when defaultRenderer is explicitly set #13868

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ca6050
Fix username duplication when plugin sets defaultRenderer
Axyss May 7, 2026
1e46096
Avoid setting FORMAT_CHANGED when both renderers are default
Axyss Jul 29, 2026
c96d2f9
Negation moved for better readability
Axyss Jul 31, 2026
154633d
fix existing old comment
Warriorrrr Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion paper-server/src/main/java/io/papermc/paper/adventure/ChatProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,8 @@ protected Void evaluate() {

private void readModernModifications(final AbstractChatEvent chatEvent, final ChatRenderer originalRenderer) {
this.flags.set(MESSAGE_CHANGED, !chatEvent.message().equals(this.paper$originalMessage));
if (originalRenderer != chatEvent.renderer()) { // don't set to false if it hasn't changed
boolean isBothDefaultRenderers = chatEvent.renderer() instanceof ChatRenderer.Default && originalRenderer instanceof ChatRenderer.Default; // Avoids default renderer format duplication
if (originalRenderer != chatEvent.renderer() && !isBothDefaultRenderers) { // don't set to true if it hasn't changed
this.flags.set(FORMAT_CHANGED, true);
}
}
Expand Down
Loading