Fix guardian fish smelting loot warning#13866
Open
Heroluex wants to merge 1 commit intoPaperMC:mainfrom
Open
Conversation
Contributor
|
Can you update the data generator too with a mention of MC-248508 to keep the output consistent with what's in the server. |
Contributor
|
actually I'm not sure it's worth fixing it before mojang given this would break datapack changing the nested loot table and expecting it to work for those mobs and the warning is harmless. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a warning caused by Guardian and Elder Guardian bonus fish loot applying
minecraft:furnace_smeltto the entireminecraft:gameplay/fishing/fishloot table.That nested fish loot table can roll
pufferfishandtropical_fish, which do not have smelting recipes. When a Guardian is on fire or killed with an enchantment in#minecraft:smelts_loot, the server attempts to smelt those items and logs a warning.This change applies
minecraft:furnace_smeltonly tocodandsalmon.