Adding more link_speed options#622
Open
crazzy wants to merge 4 commits intoPaloAltoNetworks:developfrom
Open
Conversation
This has been tested with link_speed=25000 with a PA-3410 as the target device. Haven't tested the rest but they should be perfectly valid, and it might in some cases be necessary to manually set the link speed for links with equipment from other vendors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I'm adding more options for the link_speed parameter to the panos_interface module as there are many more valid link speeds than already in the module.
Motivation and Context
I've made the PR since I need this change in order to be able to set the link speed of some of the interfaces on my PA-3410 manually when automatic detection of link speed doesn't work. I can set it in the GUI, but I need to also be able to set it using ansible since I use ansible to automate the configuration.
How Has This Been Tested?
This has been tested by setting link_speed to 25000 using a PA-3410 as target device. It has exactly the same effect as setting 25000 as the link speed using the GUI. I did no other tests but figured I'll add a few more link speed options anyway since other people might find 10G/40G/100G link speeds useful.
I haven't looked overly deep into the code, but I reckon this shouldn't impact anything else meaningfully.
Types of changes
Checklist
I'm not sure if there's any documentation external to the file, I tried looking for it, but didn't find anything. I don't know whether this affects tests and don't know where I can see whether or not the tests passes but seeing how small the change is I reckon there's not much testing to be done here.
I skimmed through the contributing document, but figured that was a whole bunch of unnecessary work for a change this small. Might seem arrogant but hard pass on that for this change.