fix(panos_check): account for failed jobs

[round3d]

Description

The panos_check checks for jobs that aren't complete. It treats jobs with job_type is None or job_result is None as not complete.
But jobs that are failed can have a missing job_result and a job_type == 'Failed-Job'.

Motivation and Context

Failed jobs should be considered complete for the purpose of panos-check.
Fixes #533

How Has This Been Tested?

I had a playbook that included panos_check that timed out because there were failed jobs.
After making the change it returns.

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist

• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes if appropriate.
• All new and existing tests passed.

[alperenkose]

panos_check actually checks if the AutoCommit job has finished successfully to find out panos device is ready to accept configurations. It doesn't aim to check for other non-complete jobs. @adambaumeister @horiagunica what do you think?

[alperenkose]

@round3d - panos_check module actually checks if the AutoCommit job has finished successfully to find out panos device is ready to accept configurations. It doesn't aim to check for other non-complete jobs. It doesn't fit into the use-case of this module unfortunately. I will close the PR if you don't have any other comments.

[round3d]

Hi @alperenkose thanks for the comment. I believe I understand what you mean that this is really about checking for an AutoCommit job not being done. We're looping every job and because of that there are some , like my example, that aren't AutoCommit jobs job_type is None or job_result is None where they cause the check to be False. Do we have to account for those that way because of timing so we don't miss an AutoCommit one?