refactor: make Filter service stateless#30
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
…rms cache Agent-Logs-Url: https://github.com/PUGX/filter-bundle/sessions/9c047773-33bb-4a5e-b572-0faf1f6a0ab4 Co-authored-by: garak <179866+garak@users.noreply.github.com>
Agent-Logs-Url: https://github.com/PUGX/filter-bundle/sessions/9c047773-33bb-4a5e-b572-0faf1f6a0ab4 Co-authored-by: garak <179866+garak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filterheld aprivate array $formskeyed by$name . $sessionId, accumulating form instances indefinitely on the service object. In long-running processes (FPM workers, Messenger consumers) this leaks memory and can bleed state across requests.Changes
$formsinstance variable — service now has zero mutable statesaveFilter()writesfilter_meta.{name}to the session containing the form class and options; forms are recreated on demand instead of cachedfilter()— replaces$form->isSubmitted()with$request->query->has('submit-filter')(logically equivalent: the old form was only submitted whensaveFilter()calledhandleRequest(), which itself gated on that param)getForm()— readsfilter_meta.{name}from session, recreates the form with the stored type/options, callshandleRequest()only whensubmit-filteris present sogetFormView()still surfaces validation errors correctly; guards against missing metadata with an early returnSession keys now written
filter.{name}filter_sort.{name}filter_meta.{name}{type, options}— new