Do not override odlparent managed versions#2622
Do not override odlparent managed versions#2622Tobianas wants to merge 3 commits intoPANTHEONtech:mainfrom
Conversation
Make odlparent as a parent of lighty-minimal-parent to set dependency versions across the project. This also requires us to disable strict ODL checkstyle as lighty.io uses its own. JIRA: LIGHTY-427 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request integrates odlparent as a parent for lighty-minimal-parent and removes explicit versions for various dependencies and plugins across the project to rely on centralized management. However, several issues were identified where removing versions will lead to build failures, specifically for the central-publishing-maven-plugin and the maven-gpg-plugin in modules that do not inherit the necessary management. Furthermore, globally skipping static analysis plugins in the minimal parent inadvertently disables the project's own quality checks. Feedback also suggests re-incorporating the SLF4J bug pattern for SpotBugs and cleaning up now-unused version properties.
Tobianas
force-pushed
the
odlparent-managed
branch
from
7593cd0 to
0d5500e
Compare
|
|
||
| <build> | ||
| <plugins> | ||
| <!-- Disable all ODL checkstyle checks since lighty.io uses its own --> |
There was a problem hiding this comment.
lighty does not have its own. where?
There was a problem hiding this comment.
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <parent> | ||
| <groupId>org.opendaylight.odlparent</groupId> |
There was a problem hiding this comment.
why? for which versions, shared where?
There was a problem hiding this comment.
By adding odlparent as a parent in here, we can override the versions for plugins across the project.
Dependency management sadly does not work for plugins as seen here:
apache/maven#4149
lighty-minimal-parent is the parent for lighty-parent, which means we can set all of the dependency versions in here.
There was a problem hiding this comment.
Is that still considered "minimal" parent?
Now when lighty-minimal-parent has odlparent as its parent, there is no need to specify these versions. JIRA: LIGHTY-427 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
This version is no longer required, as it is recieved from odlparent. JIRA: LIGHTY:427 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
Tobianas
force-pushed
the
odlparent-managed
branch
from
1285cbd to
8f62017
Compare
No warnings present anymore
|
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <parent> | ||
| <groupId>org.opendaylight.odlparent</groupId> |
There was a problem hiding this comment.
Is that still considered "minimal" parent?
2 participants
We have some dependencies we usually bump according to odlparent. Assuming they are managed by ODL we do not need to manage them in lighty.io as well.