Add some xHydro notebooks to Jenkins, enabled by default#160
Closed
tlvu wants to merge 5 commits intoupdate-2026-03from
Closed
Add some xHydro notebooks to Jenkins, enabled by default#160tlvu wants to merge 5 commits intoupdate-2026-03from
tlvu wants to merge 5 commits intoupdate-2026-03from
Conversation
Fix error like "ERROR: file or directory not found: xhydro-main/docs/notebooks/pavics_notebooks/*.ipynb". This happens because that new folder is not yet merged to main of xHydro repo. This fix allows us to be able to provision new repo in advance, before that repo is fully ready.
Fix the following error: ``` + accumulate_notebooks_to_test pavics-sdi-master/docs/source/notebooks/*.ipynb ./testall: 102: Syntax error: Bad fd number ``` This means we can not silence the listing of files.
Collaborator
Author
|
The 3 xHydro notebooks passed against the upcoming image in #159 http://jenkins.ouranos.ca/job/PAVICS-e2e-workflow-tests/job/add-xhydro-nb/5/consoleFull |
tlvu
added a commit
that referenced
this pull request
Mar 25, 2026
Add some xHydro notebooks to Jenkins, not enabled by default because they need the newer Jupyter env. Replaces #160. This allows us to merge this change immediately, without having to wait for the new Jupyter env. Also ensure empty notebook dir do not break us. This happens because xHydro PR (hydrologie/xhydro#414) that moved the notebooks to a new folder is not merged yet so that dir is currently empty on `main` branch of xHydro.
Collaborator
Author
|
Close, replaced by #162 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some xHydro notebooks to Jenkins, enabled by default.
Also ensure empty notebook dir do not break us. This happens because xHydro PR (hydrologie/xhydro#414) that moved the notebooks to a new folder is not merged yet so that dir is currently empty on
mainbranch of xHydro.