make nix detection faster#60
Draft
victorbash400 wants to merge 1 commit into
Draft
Conversation
victorbash400
added
upstream-import
victorbash400
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imported from upstream pull request fastfetch-cli/fastfetch pull request 2113: fastfetch-cli#2113
Original author: lhz07
Original state: OPEN
Original labels: none
Original assignees: none
Counting nix-user and nix-default sequentially is quite slow.
On my MacBook, it takes around 120 ms (measured with
fastfetch --stat).This PR changes the implementation to call
nix-storein parallel, reducing the time to about 80 ms on my machine.It also removes the hash cache. In practice, the cache only improves performance by roughly 10 ms, while a cache miss (when the hash changes) can take up to 230 ms, making the overall behavior worse.