Fix NumPy 1.24+ compatibility and ValueError shape crashes#1042
Open
fayerman-source wants to merge 1 commit into
Open
Fix NumPy 1.24+ compatibility and ValueError shape crashes#1042fayerman-source wants to merge 1 commit into
fayerman-source wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two critical compatibility issues when running SadTalker on modern python stacks:
NumPy 1.24+ AttributeError:
In
src/face3d/util/my_awing_arch.py, callingnp.floatraisesAttributeError: module 'numpy' has no attribute 'float'on NumPy versions 1.24 and above. This is fixed by using Python's built-infloattype.ValueError setting array element with a sequence:
In
src/face3d/util/preprocess.py,trans_params = np.array([w0, h0, s, t[0], t[1]])raisesValueError: setting an array element with a sequencein newer NumPy versions when elements are inhomogeneous. This is fixed by explicitly casting parameters to scalar floats.