Skip to content

Labels: save multiline parameter if needed #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LANDAISB merged 2 commits into from
Mar 30, 2026
Merged

Labels: save multiline parameter if needed #25

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83ed5e9
Labels: save multiline parameter if needed
LANDAISB Mar 30, 2026
f0016d4
Fix from review
LANDAISB Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Toplo-Serialization-Stash/ToLabel.extension.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,10 @@ Extension { #name : #ToLabel }
ToLabel >> stashAccessorsForText [

<stashAccessors>
^ { #text }
| accessors |
accessors := OrderedCollection with: #text.
self isMultiLine ifTrue:[
accessors add: #multiLine: -> #isMultiLine
].
^ accessors
]
8 changes: 6 additions & 2 deletions src/Toplo-Serialization-Tests/ToSerializerTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,10 +371,14 @@ ToSerializerTest >> testToLabel [

| origin |
origin := ToLabel new text: 'hello' asRopedText; yourself.

origin beMultiLine.
Copy link
Copy Markdown
Contributor

@YannLeGoff YannLeGoff Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would create 2 test methods.

It would be easier to debug in the future if each test only focus on one specific aspect of the serialization.

One test for the "text", one test for the "multiline"

self
test: origin
on: [ :element | self assert: element text asString equals: 'hello' ]
on: [ :element |
self assert: element text asString equals: 'hello'.
self assert: element isMultiLine
].

]

{ #category : #tests }
Expand Down
Loading